function popular_collection_loop($atts) { ob_start(); extract( shortcode_atts( array( 'category' => '' ), $atts ) ); //var_dump($atts['category']); $arg = array( 'post_type' => 'popular_collection', 'posts_per_page' => -1, 'tax_query' => array( array( 'taxonomy' => 'popular_collection_category', 'terms' => $atts['category'], 'field' => 'slug', ) ) ); // echo '<pre>'; // print_r($arg); $popular_collectionPost = new WP_Query($arg); ?> <div id="mainpopular_collection"> <?php if ($popular_collectionPost->have_posts()) : ?> <?php while ($popular_collectionPost->have_posts()) : ?> <?php $popular_collectionPost->the_post(); ?> <?php endwhile; ?> <?php endif; ?> </div> <?php wp_reset_postdata(); $myvar = ob_get_clean(); return $myvar; } add_shortcode('popular_collection_gird', 'popular_collection_loop');